CheckoutKit Logger: NSLock guaranteed#86
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
Conversation
11 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 13, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
1ff7318 to
1b2c323
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/configure-only-checkoutkit-state
branch
from
0453ef5 to
3aaa3db
Compare
React Native — Coverage Report
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
1b2c323 to
a9cef3b
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/configure-only-checkoutkit-state
branch
from
0763c3b to
0955280
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
a9cef3b to
0690561
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/configure-only-checkoutkit-state
branch
from
0955280 to
c7e8091
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
0690561 to
29a0e02
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/configure-only-checkoutkit-state
branch
from
c7e8091 to
945d4b6
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
29a0e02 to
673bb39
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/configure-only-checkoutkit-state
branch
from
945d4b6 to
fe87622
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
673bb39 to
29722dd
Compare
kieran-osgood-shopify
changed the base branch from
kieran-osgood/swift6/configure-only-checkoutkit-state
to
graphite-base/86
kieran-osgood-shopify
force-pushed
the
graphite-base/86
branch
from
fe87622 to
63e7604
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
29722dd to
7c8db7f
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/86
to
kieran-osgood/swift6/configure-only-checkoutkit-state
11 tasks
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/configure-only-checkoutkit-state
branch
from
63e7604 to
b28434d
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
7c8db7f to
f8b8244
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/synchronous-logger-state
branch
from
f8b8244 to
db98f08
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/swift6/configure-only-checkoutkit-state
branch
from
b28434d to
1d9c9a8
Compare
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Not much to say about this PR other than it reuses the LockedValue generic class from #85 to make concurrent access to the shared logger concurrency safe
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
platforms/swift/ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.